Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: change the diameter property of loading icon to a string instead of number #3341

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Nov 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The diameter property currently takes a number. This means the number is always a fixed value, currently set in pixel.

Fixes: N/A

What is the new behavior?

Change diameter property to accept a string so the diameter number can pixel, rem, etc.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: The diameter property is now a string and the CSS units need to be specified.

Other information

@xelaint xelaint added the package: design @daffodil/design label Nov 7, 2024
@xelaint xelaint requested a review from a team as a code owner November 7, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant