Finished Practice PR #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auberonedu
reviewed
Jan 22, 2025
| public class ListPractice { | ||
|
|
||
|
|
||
| public static void main(String[] args) { | ||
| // Create an empty ArrayList of Strings and assign it to a variable of type List | ||
|
|
||
| ArrayList<String> list = new ArrayList<String>(); |
There was a problem hiding this comment.
Remember to use interface types where appropriate (List)
Comment on lines
+32
to
+34
| for(String entry : mapsPractice.keySet()){ | ||
| System.out.println("Key: " + entry + ". Value: " + mapsPractice.get(entry)); | ||
| } |
There was a problem hiding this comment.
This works! In the future, also consider entrySet
Comment on lines
+11
to
+12
| public String name = ""; | ||
| private int age = -99; |
There was a problem hiding this comment.
For these it's probably best not to set the defaults. They will automatically default to null and 0.
Comment on lines
+16
to
+19
| public Person(String x, int y){ | ||
| name = x; | ||
| age = y; | ||
| } |
There was a problem hiding this comment.
This works, but try to use more descriptive variable names in the future. A caller of this class will be confused as to what x and y represent.
Comment on lines
+39
to
+41
| public int birthYear(int currentYear){ | ||
| return(currentYear - age); | ||
| } |
There was a problem hiding this comment.
Here and elsewhere we don't need the parentheses after return. You can just say return currentYear - age;
Comment on lines
+43
to
+45
| public String getName(){ | ||
| return(name); | ||
| } |
There was a problem hiding this comment.
We don't need getters for a public instance variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.