[ecocode challenge 2024/Hafnium] Improve rule EC67 : Handle case when i++ is located within a binary expression or a method parameter #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore rule EC67 when i++ is located within a binary expression
hocinehacherouf
changed the title
hocinehacherouf
changed the title
|
dedece35
requested changes
May 31, 2024
There was a problem hiding this comment.
can you please check all tasks in DoD requirement (example of lack : no CHANGELOG.md file updated) ?
here : https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#check-definition-of-done-for-new-rule-implementation
|
@dedece35 I updated the file CHANGELOG.md and I created a PR on the repo |
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore rule EC67 when i++ is located within a binary expression or as a method parameter
Closes #4