Added Swift version for EC528 #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedece35
requested changes
May 30, 2024
| Shaking or vibrating an iOS device is possible using `UIFeedbackGenerator`. | ||
| Behind this effect stands a specific hardware component, the Haptic Engine, which consumes power. As a consequence, its usage should be carefully considered, especially if its added value is not clear. | ||
|
|
||
| == Noncompliant Code Example |
There was a problem hiding this comment.
ok for "non compliant example" ... but no "compliant example" ?
There was a problem hiding this comment.
no there is no compliant example because the compliant example is not to use it at all :)
There was a problem hiding this comment.
maybe write it explicitly in the description at the top, no ?
dedece35
requested changes
Jun 8, 2024
| Shaking or vibrating an iOS device is possible using `UIFeedbackGenerator`. | ||
| Behind this effect stands a specific hardware component, the Haptic Engine, which consumes power. As a consequence, its usage should be carefully considered, especially if its added value is not clear. | ||
|
|
||
| == Noncompliant Code Example |
There was a problem hiding this comment.
maybe write it explicitly in the description at the top, no ?
|
This PR has been automatically marked as stale because it has no activity for 60 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A port of EC528 rule.
This rule already exists for Android / Java.
Addresses issue #313