Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add header #22

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Feature/add header #22

merged 5 commits into from
Jun 5, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Jun 5, 2024 •
edited
Loading

Closes #21

For mobile screens:
image

For larger screens:
image

@doriengr doriengr added the review label Jun 5, 2024
@doriengr doriengr self-assigned this Jun 5, 2024
@doriengr doriengr requested a review from choffmann June 5, 2024 17:35
@choffmann choffmann force-pushed the develop branch 4 times, most recently from 34c1742 to 7d2122c Compare June 5, 2024 18:04
choffmann
choffmann approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im impressed 👍 The only thing I noticed when testing on my phone was that I tried to click outside the drawer rather than on the cross to close it.

@doriengr
Copy link
Contributor Author

doriengr commented Jun 5, 2024

@choffmann You are right. I created a tool that checks the clicks outside of the overlay. Thank you for noticing that!

@choffmann choffmann merged commit e4a5004 into develop Jun 5, 2024
1 check passed
@choffmann choffmann deleted the feature/add-header branch June 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann choffmann approved these changes

Assignees

@doriengr doriengr

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add header and main-navigation
2 participants
@doriengr @choffmann