Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add faq section #24

Merged
merged 5 commits into from
Jun 6, 2024
Merged

feat: add faq section #24

merged 5 commits into from
Jun 6, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Jun 6, 2024

Closes #23

image

@doriengr doriengr added the review label Jun 6, 2024
@doriengr doriengr requested a review from choffmann June 6, 2024 11:28
@doriengr doriengr self-assigned this Jun 6, 2024
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue with the mobile view. Tested on iPhone Safari browser

image

@doriengr
Copy link
Contributor Author

doriengr commented Jun 6, 2024

@choffmann What browser are you using?

@choffmann
Copy link
Member

@choffmann What browser are you using?

Safari on iPhone

@doriengr
Copy link
Contributor Author

doriengr commented Jun 6, 2024

@choffmann What browser are you using?

Safari on iPhone

Got it 👍 Thanks

@doriengr doriengr requested a review from choffmann June 6, 2024 17:02
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now it's working 🔥 but now it closes as soon as I scroll up on mobile.

RPReplay_Final1717694755.mp4

@doriengr
Copy link
Contributor Author

doriengr commented Jun 6, 2024

Yes, now it's working 🔥 but now it closes as soon as I scroll up on mobile.

RPReplay_Final1717694755.mp4

Oh wow … from one bug to another. I currently do not have access to a device with IOS and in Safari it works as expected. Can you test it again if its now working? Sorry for the cross-browser problems. Safari always needs an extra invitation …

@doriengr doriengr requested a review from choffmann June 6, 2024 17:46
@choffmann
Copy link
Member

Yep, now it work 💪

@choffmann choffmann merged commit 9e39bb9 into develop Jun 6, 2024
1 check passed
@choffmann choffmann deleted the feature/add-faq-section branch June 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add faq section with accordions
2 participants