Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add homepage hero #50

Merged
merged 13 commits into from
Jun 18, 2024
Merged

feat: add homepage hero #50

merged 13 commits into from
Jun 18, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Jun 15, 2024

refs #49

The popups and the scrolling down effect is not implemented yet. In this MR I just added the illustrations to find a good starting point.

@doriengr doriengr self-assigned this Jun 15, 2024
@doriengr doriengr changed the title Feature/add homepage hero feat: add homepage hero Jun 15, 2024
@doriengr doriengr marked this pull request as ready for review June 16, 2024 07:56
@doriengr doriengr requested a review from choffmann June 16, 2024 07:56
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think many people use this site in landscape format on their mobile phone, but it looks a bit weird. Overall, though, it looks good to me.

image

@doriengr doriengr merged commit 82b1bf5 into develop Jun 18, 2024
1 check passed
@doriengr doriengr deleted the feature/add-homepage-hero branch June 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants