Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add not found page #54

Merged
merged 4 commits into from
Jun 20, 2024
Merged

feat: add not found page #54

merged 4 commits into from
Jun 20, 2024

Conversation

doriengr
Copy link
Contributor

Closes #40

Depending on #51

@doriengr doriengr added the doing label Jun 16, 2024
@doriengr doriengr self-assigned this Jun 16, 2024
@doriengr doriengr changed the title Feature/add not found page feat: add not found page Jun 18, 2024
@doriengr doriengr requested a review from choffmann June 18, 2024 16:05
@doriengr doriengr added review and removed doing labels Jun 18, 2024
@doriengr doriengr marked this pull request as ready for review June 18, 2024 16:05
choffmann
choffmann approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 🥇 I like how the cable is animated

@doriengr doriengr merged commit 7aec460 into develop Jun 20, 2024
2 checks passed
@doriengr doriengr deleted the feature/add-not-found-page branch June 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann choffmann approved these changes

Assignees

@doriengr doriengr

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 error page
2 participants
@doriengr @choffmann