Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hero homepage overlays #56

Merged
merged 21 commits into from
Jul 2, 2024

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Jun 18, 2024

Closes #49

Testing:

  1. As soon as the page is opened for the first time, the overlay is opened automatically. A card should appear that says something about the project, but can also start the animation.
  2. Check if the animation can be started from the welcome card
  3. Click through the popups and close the overlay
  4. Click the button in the hero to start the animation again. Check if everything works as expected.
  5. Reload the page and check, if the welcome-overlay is not started again. The cookie green_ecolution_initial_load should now be set.
  6. Start the animation again over the button in the hero section.

Testing Edge cases:

  1. Delete the cookie if it is currently set. Open the website with a screen size of less than 1280px and check that the cookie is not set. Also check, that the animation is not started.
  2. Open the site again with a screen size larger than 1279px. Check if the animation is started. Than resize the screen size to a mobile width and check if the animation is hidden.
  3. Reload, scroll down and check if the website is scrolling up automatically after the animation is started.

🙏

@doriengr doriengr self-assigned this Jun 18, 2024
@doriengr doriengr added the doing label Jun 18, 2024
@doriengr doriengr marked this pull request as ready for review June 23, 2024 08:00
@doriengr doriengr added review and removed doing labels Jun 23, 2024
@doriengr doriengr requested a review from choffmann June 23, 2024 08:01
@choffmann choffmann added the deploy Set on PR to create temporary deployment label Jun 23, 2024
Copy link

Deployment of PR #56 successful 🚀

You can access the deployment at pr-56.website.dev.green-ecolution.de to review the changes 👀

⚠️ Please note that this deployment is temporary and will be deleted after the PR is closed.

@choffmann
Copy link
Member

@doriengr I noticed a small issue when the first dialog box appears and I click outside it. The animation stops and the dialog is still visible

bug-website-animation

Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@doriengr doriengr merged commit feb8af0 into develop Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Set on PR to create temporary deployment review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hero of startpage
2 participants