Fix: Show error message if user settings can't be saved #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
When the http request returned an error the error message was not shown while changing the user settings in the corresponding dialog. It broke while introducing the JS form validation because its validate function isn't a promise in contrast to the onSave handler.
bjoernricks
force-pushed
the
usersettings-dialog-save-error
branch
from
82a4f47 to
a0a72e6
Compare
jhelmold
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Show error message if user settings can't be saved
Why
When the http request returned an error the error message was not shown while changing the user settings in the corresponding dialog. It broke while introducing the JS form validation because its validate function isn't a promise in contrast to the onSave handler.
References
GEA-175
Checklist