-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main #1097
Main #1097
Conversation
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
From what I see on the first view, you will probably need to run this with our CI tooling, because I expect these to fail (linting and formatting with ruff
and black
!).
I also noticed your copyright header, you may want to change these into our new format, that reduces the overhead in LoC for the header.
I will take another deep dive through your contribution tomorrow!
@martinboller I would really love to merge this - is there any chance, that you fix up the stuff? |
Co-authored-by: Jaspar S. <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: Jaspar S. <[email protected]>
Head branch was pushed to by a user without write access
Will these changes satisfy requirements or am I missing something (or everything) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
- Coverage 53.55% 47.81% -5.74%
==========================================
Files 15 17 +2
Lines 1083 1213 +130
==========================================
Hits 580 580
- Misses 503 633 +130 ☔ View full report in Codecov by Sentry. |
No actually my suggestions were just examples, e.g. the Copyright header should have been updated in every file ... |
merged through #1112 |
What
Additional and changed scripts for maintaining Greenbone and automating the creation of credentials, schedules, alerts, targets, tasks, tags and filters.
Why
To automate the creation of a completely configured Greenbone Scanner
References
Original gvm-tools scripts.
[Install new scanner], alternatively
[clean-scanner]
[Prepare relevant CSV files for create-.gmp.py scripts]
[create Credentials]
[Create Schedules
[Create Alerts]
[Create Targets]
[Create tasks}
[Create Tags]
[Create filters]
[List objects created w. list-.gmp.py]
[Run task(s)]
[export-csv-report.gmp.py]
[export-pdf-report.gmp.py]
[Verify Reports]