Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #1097

Closed
wants to merge 4 commits into from
Closed

Main #1097

wants to merge 4 commits into from

Conversation

martinboller
Copy link
Contributor

What

Additional and changed scripts for maintaining Greenbone and automating the creation of credentials, schedules, alerts, targets, tasks, tags and filters.

Why

To automate the creation of a completely configured Greenbone Scanner

References

Original gvm-tools scripts.

  • Tests
    [Install new scanner], alternatively
    [clean-scanner]
    [Prepare relevant CSV files for create-.gmp.py scripts]
    [create Credentials]
    [Create Schedules
    [Create Alerts]
    [Create Targets]
    [Create tasks}
    [Create Tags]
    [Create filters]
    [List objects created w. list-
    .gmp.py]
    [Run task(s)]
    [export-csv-report.gmp.py]
    [export-pdf-report.gmp.py]
    [Verify Reports]

@martinboller martinboller requested a review from a team as a code owner April 18, 2024 16:10
@greenbonebot greenbonebot enabled auto-merge (rebase) April 18, 2024 16:10
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

Copy link
Member

@y0urself y0urself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
From what I see on the first view, you will probably need to run this with our CI tooling, because I expect these to fail (linting and formatting with ruff and black!).
I also noticed your copyright header, you may want to change these into our new format, that reduces the overhead in LoC for the header.

I will take another deep dive through your contribution tomorrow!

scripts/create-alerts-from-csv.gmp.py Outdated Show resolved Hide resolved
scripts/create-alerts-from-csv.gmp.py Outdated Show resolved Hide resolved
@y0urself
Copy link
Member

y0urself commented May 3, 2024

@martinboller I would really love to merge this - is there any chance, that you fix up the stuff?

auto-merge was automatically disabled May 3, 2024 17:50

Head branch was pushed to by a user without write access

@greenbonebot greenbonebot enabled auto-merge (rebase) May 3, 2024 17:50
auto-merge was automatically disabled May 3, 2024 17:50

Head branch was pushed to by a user without write access

@greenbonebot greenbonebot enabled auto-merge (rebase) May 3, 2024 17:51
@martinboller
Copy link
Contributor Author

Will these changes satisfy requirements or am I missing something (or everything)

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 130 lines in your changes are missing coverage. Please review.

Project coverage is 47.81%. Comparing base (fdb6dec) to head (5968d5c).
Report is 21 commits behind head on main.

Files Patch % Lines
scripts/stop-scans-from-csv.py 0.00% 66 Missing ⚠️
scripts/start-scans-from-csv.py 0.00% 64 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
- Coverage   53.55%   47.81%   -5.74%     
==========================================
  Files          15       17       +2     
  Lines        1083     1213     +130     
==========================================
  Hits          580      580              
- Misses        503      633     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0urself
Copy link
Member

Will these changes satisfy requirements or am I missing something (or everything)

No actually my suggestions were just examples, e.g. the Copyright header should have been updated in every file ...
Also running black and ruff in every file has not been done ...

@y0urself
Copy link
Member

merged through #1112

@y0urself y0urself closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants