Added test for smb_cmac_aes_signature and smb_gmac_aes_signature

greenbone · Nov 27, 2024 · aa35d1c · aa35d1c
1 parent dcdff4c
commit aa35d1c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/rust/src/nasl/builtin/cryptographic/smb.rs b/rust/src/nasl/builtin/cryptographic/smb.rs
@@ -16,7 +16,7 @@ use nasl_function_proc_macro::nasl_function;
 fn smb_cmac_aes_signature(key: &str, buf: &str) -> Result<NaslValue, FunctionErrorKind> {
     let key_bytes = key.as_bytes();
     let buf_bytes = buf.as_bytes();
-    let mut cmac = Cmac::<Aes128>::new_from_slice(&key_bytes)
+    let mut cmac = Cmac::<Aes128>::new_from_slice(key_bytes)
         .map_err(|e| FunctionErrorKind::Diagnostic(e.to_string(), None))?;
     cmac.update(buf_bytes);
     let finish = cmac::Mac::finalize(cmac).into_bytes();
@@ -28,8 +28,8 @@ fn smb_gmac_aes_signature(key: &str, buf: &str, iv: &str) -> Result<NaslValue, F
     let key_bytes = key.as_bytes();
     let buf_bytes = buf.as_bytes();
     let iv_bytes = iv.as_bytes();
-    let gmac = Aes128Gcm::new_from_slice(&key_bytes).unwrap();
-    let nonce = Nonce::from_slice(&iv_bytes);
+    let gmac = Aes128Gcm::new_from_slice(key_bytes).unwrap();
+    let nonce = Nonce::from_slice(iv_bytes);
     let auth = gmac.encrypt(nonce, buf_bytes.as_ref()).unwrap();
     Ok(auth.into())
 }

diff --git a/rust/src/nasl/builtin/cryptographic/tests/smb.rs b/rust/src/nasl/builtin/cryptographic/tests/smb.rs
@@ -12,5 +12,22 @@ mod tests {
     #[test]
     fn smb_cmac_aes_signature() {
         let mut t = TestBuilder::default();
+        t.run(r#"key = "1274637383948293";"#);
+        t.run(r#"buf = "1274637383948293";"#);
+        t.ok(
+            r#"smb_cmac_aes_signature(key:key,buf:buf);"#,
+            NaslValue::Data(decode_hex("73C1B26E84FFC51037E057734B8AC8E2").unwrap()),
+        );
+    }
+    #[test]
+    fn smb_gmac_aes_signature() {
+        let mut t = TestBuilder::default();
+        t.run(r#"key = "1274637383948293";"#);
+        t.run(r#"buf = "1274637383948293";"#);
+        t.run(r#"iv = "28374928";"#);
+        t.ok(
+            r#"smb_gmac_aes_signature(key:key,buf:buf,iv:iv);"#,
+            NaslValue::Data(decode_hex("73C1B26E84FFC51037E057734B8AC8E2").unwrap()),
+        );
     }
 }