Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: VT preferences #1786

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix: VT preferences #1786

merged 1 commit into from
Dec 16, 2024

Conversation

Kraemii
Copy link
Member

@Kraemii Kraemii commented Dec 13, 2024

When checking the preferences for VTs set by the user, it used the value provided by the script itself instead the one provided by the user (except for type checkbox), so many values were not set to an empty string.

SC-1211
What:

Why:

How:

Checklist:

  • Tests
  • PR merge commit message adjusted

When checking the preferences for VTs set by the user, it used the value
provided by the script itself instead the one provided by the user (except
for type checkbox), so many values were not set to an empty string.
@Kraemii Kraemii requested a review from a team as a code owner December 13, 2024 15:27
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 39bfda6.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions github-actions bot added the patch_release creates a patch release label Dec 13, 2024
@Kraemii Kraemii enabled auto-merge (rebase) December 16, 2024 08:16
@Kraemii Kraemii merged commit dbe087e into main Dec 16, 2024
5 checks passed
@Kraemii Kraemii deleted the fix-vt-prefs branch December 16, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch_release creates a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants