-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single year parameter flag to pontos-update-header #1021
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 103 103
Lines 6960 6981 +21
Branches 986 990 +4
=======================================
+ Hits 6290 6309 +19
- Misses 471 472 +1
- Partials 199 200 +1 ☔ View full report in Codecov by Sentry. |
b0c6521
to
084f204
Compare
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Leszek. Thank you for your contribution!
I wonder if it would make sense to implement the ability to revert the from-to
copyright statement, if the single-year
argument is passed? It would probably improve the continuity in a single repository to have either single-year
or from-to
copyright header format.
a4f11a7
to
9beec24
Compare
As suggested, added the feature to change existing multi-year license headers into single-year ones. |
9beec24
to
111d573
Compare
No point for calling _get_modified_year() for excluded files.
To enable using only creation year for header license.
111d573
to
df21d08
Compare
What
Add single_year flag to pontos-update-header that skips updating headers with additional modified year (YYYY-YYYY) and retains only creation year.
Why
To be able to use the tool and adhering to internal requirements (that discourage using from-to years), which makes licenses easier to maintain.