Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single year parameter flag to pontos-update-header #1021

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

llugin
Copy link
Contributor

@llugin llugin commented Jul 11, 2024

What

Add single_year flag to pontos-update-header that skips updating headers with additional modified year (YYYY-YYYY) and retains only creation year.

Why

To be able to use the tool and adhering to internal requirements (that discourage using from-to years), which makes licenses easier to maintain.

@llugin llugin requested a review from a team as a code owner July 11, 2024 11:31
@greenbonebot greenbonebot enabled auto-merge (rebase) July 11, 2024 11:31
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.37%. Comparing base (4fdbe3d) to head (df21d08).

Files Patch % Lines
pontos/updateheader/updateheader.py 94.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files         103      103           
  Lines        6960     6981   +21     
  Branches      986      990    +4     
=======================================
+ Hits         6290     6309   +19     
- Misses        471      472    +1     
- Partials      199      200    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llugin llugin force-pushed the add-single-year-parameter-flag branch 5 times, most recently from b0c6521 to 084f204 Compare July 11, 2024 12:00
@llugin llugin marked this pull request as draft July 12, 2024 07:59
auto-merge was automatically disabled July 12, 2024 07:59

Pull request was converted to draft

@llugin llugin marked this pull request as ready for review July 12, 2024 08:18
@greenbonebot greenbonebot enabled auto-merge (rebase) July 22, 2024 07:47
Copy link
Member

@y0urself y0urself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Leszek. Thank you for your contribution!

I wonder if it would make sense to implement the ability to revert the from-to copyright statement, if the single-year argument is passed? It would probably improve the continuity in a single repository to have either single-year or from-to copyright header format.

pontos/updateheader/updateheader.py Show resolved Hide resolved
@llugin llugin force-pushed the add-single-year-parameter-flag branch 5 times, most recently from a4f11a7 to 9beec24 Compare August 9, 2024 15:25
@llugin
Copy link
Contributor Author

llugin commented Aug 9, 2024

As suggested, added the feature to change existing multi-year license headers into single-year ones.

@y0urself y0urself force-pushed the add-single-year-parameter-flag branch from 9beec24 to 111d573 Compare August 12, 2024 10:15
@llugin llugin force-pushed the add-single-year-parameter-flag branch from 111d573 to df21d08 Compare August 12, 2024 19:56
@greenbonebot greenbonebot merged commit 8ceb855 into main Aug 13, 2024
20 checks passed
@greenbonebot greenbonebot deleted the add-single-year-parameter-flag branch August 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants