Improve CPE parsing #915
Merged
Improve CPE parsing #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise a descriptive error message during converting a CPE to the URI format (CPE v2.2) if transforming a part of the CPE fails.
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
force-pushed
the
cpe-parsing
branch
from
d25fe2f
to
9ecfdd7
Compare
In the real world CPEs contain escaped colons in the vendor or product parts exist. Therefore allow to parse these CPE strings. Currently parsing a CPE string like `cpe:2.3:a:foo\\:bar:...` wouldn't work. But as far as I can see this is neither a valid CPE nor a real world scenario.
bjoernricks
force-pushed
the
cpe-parsing
branch
from
9ecfdd7
to
c8814d0
Compare
y0urself
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve parsing of CPEs
Why
It wasn't possible to parse a CPE like
cpe:2.3:a:foo\:bar:baz:...where the vendor isfoo:bar. Additionally it wasn't easy to spot where the parsing did go wrong.Checklist