Change: Assume UTC when no offset it specified #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR changes the behavior of handling datetime objects. Instead of assuming the local timezone, we should assume UTC instead.
Why
NVD always returns datetime objects in UTC, so we should mark them as those. The only documentation, I've found regarding this is
datetime objects in the API response are always returned with a zero offset from UTC
(see https://nvd.nist.gov/general/news/api-20-announcements).Example:
Current behavior:
With this patch:
References
The LoC form this PR have been first added in 2e397c3.
Checklist