Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Performance improvement for parsing CPEs #944

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

bjoernricks
Copy link
Contributor

What

Performance improvement for parsing CPEs

Why

Use a list to collect string parts instead of concat them directly.

Use a list to collect string parts instead of concat them directly.
@bjoernricks bjoernricks requested a review from a team as a code owner December 12, 2023 15:01
@bjoernricks bjoernricks enabled auto-merge (rebase) December 12, 2023 15:01
@bjoernricks bjoernricks added the make release To trigger GitHub release action. label Dec 12, 2023
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f62b35) 90.57% compared to head (1826868) 90.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          97       97           
  Lines        6811     6811           
  Branches      973      973           
=======================================
  Hits         6169     6169           
  Misses        442      442           
  Partials      200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernricks bjoernricks merged commit 2e3fe01 into main Dec 12, 2023
21 checks passed
@bjoernricks bjoernricks deleted the small-performance-improvement branch December 12, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants