Cleanup git module #963
Merged
Cleanup git module #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All git related classes should be imported from `pontos.git`. Other classes, modules, functions, variables, ... not imported into `pontos.git` are considered private.
The `pontos.git.git` module should not be considered as a public API of pontos. Therefore rename it to `pontos.git._git` to user Python naming convention to mark it as a private module.
The `pontos.git.status` module should not be considered as a public API of pontos. Therefore rename it to `pontos.git._status` to user Python naming convention to mark it as a private module.
Conventional Commits Report
🚀 Conventional commits found. |
y0urself
approved these changes
Jan 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 90.66% 90.66% -0.01%
==========================================
Files 97 97
Lines 6833 6832 -1
Branches 976 976
==========================================
- Hits 6195 6194 -1
Misses 438 438
Partials 200 200 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cleanup git module
Why
Make it obvious what's part of the
pontos.gitAPI and which parts are considered private.Checklist