Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Revert local changes if creating a GitHub release fails #981

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bjoernricks
Copy link
Contributor

What

Revert local changes if creating a GitHub release fails

Why

Improve the create release "workflow" by reverting the changes (tag and version update commit) if creating a GitHub release via the API did fail.

Checklist

  • Tests

Improve the create release "workflow" by reverting the changes (tag and
version update commit) if creating a GitHub release via the API did
fail.
@bjoernricks bjoernricks requested a review from a team as a code owner February 6, 2024 09:14
@bjoernricks bjoernricks enabled auto-merge (rebase) February 6, 2024 09:15
Copy link

github-actions bot commented Feb 6, 2024

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@bjoernricks bjoernricks added make release To trigger GitHub release action. and removed make release To trigger GitHub release action. labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85ad900) 90.22% compared to head (fe8ba72) 90.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         103      103           
  Lines        6946     6950    +4     
  Branches      984      984           
=======================================
+ Hits         6267     6271    +4     
  Misses        478      478           
  Partials      201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@y0urself y0urself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always wanted this 🚀

@bjoernricks bjoernricks merged commit 2ee191e into main Feb 6, 2024
21 checks passed
@bjoernricks bjoernricks deleted the release-rollback branch February 6, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants