Skip to content

Commit

Permalink
This is the v3.0.0 commit.
Browse files Browse the repository at this point in the history
Squashed commit of the following:

commit 3a5bf4b
Author: Greg Chapman <[email protected]>
Date:   Fri Nov 10 12:29:23 2023 -0800

    Date in LICENSE wasn't right.

commit 2a7e62e
Author: Greg Chapman <[email protected]>
Date:   Fri Nov 10 12:23:24 2023 -0800

    Update docs again, to pick up new copyright years.

commit afc1633
Author: Greg Chapman <[email protected]>
Date:   Fri Nov 10 12:22:28 2023 -0800

    Update copyright years.

commit a07df54
Author: Greg Chapman <[email protected]>
Date:   Fri Nov 10 12:18:12 2023 -0800

    More last-minute tweaks.

commit 0631249
Author: Greg Chapman <[email protected]>
Date:   Fri Nov 10 12:14:08 2023 -0800

    Last tweaks for release 3.

commit 52bb06b
Author: Greg Chapman <[email protected]>
Date:   Fri Nov 10 11:32:39 2023 -0800

    Re-generated docs.

commit dd4e6d8
Author: Greg Chapman <[email protected]>
Date:   Tue Nov 7 21:24:46 2023 -0800

    Handle spanners whose end is not in the score (I've seen a few), by pretending the end element isn't there.

commit 21c7d7a
Author: Greg Chapman <[email protected]>
Date:   Wed Oct 25 14:21:14 2023 -0700

    Support comparison of metadata.  Detail level is now bits ORed together.
    Squashed commit of the following:

    commit f51b59d
    Author: Greg Chapman <[email protected]>
    Date:   Sat Oct 14 16:53:38 2023 -0700

        Be judicious about Contributor and Text metadata annotations, so non-meaningful diffs don't show up.

    commit 93e3ed5
    Author: Greg Chapman <[email protected]>
    Date:   Sat Aug 26 11:38:34 2023 -0700

        Check for metadata keys that start with 'raw:', 'meiraw:', 'humdrumraw:' more carefully ('raw:' in key is a bit cavalier).

    commit cbf501f
    Author: Greg Chapman <[email protected]>
    Date:   Tue Aug 22 14:49:27 2023 -0700

        Don't compare metadata that is uninterestingly different (e.g. fileFormat and various verbatim transcriptions of format-specific metadata).

    commit 20774c1
    Author: Greg Chapman <[email protected]>
    Date:   Sun Aug 20 11:38:04 2023 -0700

        Proper support (and doc) for new Metadata detail level.  Full internal support for any combination of Detail bits.

    commit 0f43bc1
    Author: Greg Chapman <[email protected]>
    Date:   Sat Aug 19 16:25:44 2023 -0700

        Don't compare meiraw:meiHead metadata... the differences are redundant.

    commit 5856884
    Author: Greg Chapman <[email protected]>
    Date:   Fri Aug 18 09:57:36 2023 -0700

        Don't crash if there is no metadata in the score.

    commit 0f2642a
    Author: Greg Chapman <[email protected]>
    Date:   Thu Aug 17 17:40:37 2023 -0700

        Sort metadata primitives by hand (music21 can't do it).

    commit 1d63b75
    Author: Greg Chapman <[email protected]>
    Date:   Thu Aug 17 16:36:53 2023 -0700

        Don't compare metadata 'software' key; it's almost always different between two different versions of a score file.

    commit 07e5042
    Author: Greg Chapman <[email protected]>
    Date:   Sat Aug 12 16:12:11 2023 -0700

        Compare metadata if detail & DetailLevel.Metadata != 0.
        Includes some (but not all) of the necessary changes to make DetailLevel
        a lot more flexible.  What's missing is: full definitions of all the bits,
        and command line support for the new options.

commit 1badb6a
Author: Greg Chapman <[email protected]>
Date:   Sun Aug 6 12:55:42 2023 -0700

    Squash merge of gregc/meiWriterStuff.

    Squashed commit of the following:

    commit c4970cf
    Author: Greg Chapman <[email protected]>
    Date:   Sat Aug 5 12:55:55 2023 -0700

        A fix to the new "ignore rest positions, but do all the rest of style" undocumented feature.

    commit c3a7783
    Author: Greg Chapman <[email protected]>
    Date:   Sat Aug 5 12:19:21 2023 -0700

        Undocumented ability to disable rest position comparison (for use by converter21 tests that compare Humdrum import vs MEI import of verovio-converted Humdrum; verovio makes up rest positions for every rest that isn't explicitly positioned)

    commit b097632
    Author: Greg Chapman <[email protected]>
    Date:   Mon Jul 31 14:49:30 2023 -0700

        If detail includes style, compare rest positioning.
        No longer compare chord.tie, since it is simply a derivation of all the note.tie in the chord.

    commit 30eb0a9
    Author: Greg Chapman <[email protected]>
    Date:   Fri Jul 21 17:44:19 2023 -0700

        When annotating RepeatBrackets, include .overrideDisplay if present.

    commit 67e7fe6
    Author: Greg Chapman <[email protected]>
    Date:   Sun Jul 9 10:47:58 2023 -0700

        Finish up support for comparing bowed and fingered tremolos.

    commit 676c783
    Author: Greg Chapman <[email protected]>
    Date:   Fri Jun 16 10:52:29 2023 -0700

        Update tests to (1) use converter21's converters, (2) adjust expectations for that, and (3) fix up some tie stuff to match new reality.

    commit fb1c766
    Author: Greg Chapman <[email protected]>
    Date:   Wed Jun 14 13:50:40 2023 -0700

        Fix tie diff.

    commit 1deca2e
    Author: Greg Chapman <[email protected]>
    Date:   Mon May 29 16:30:54 2023 -0700

        Don't crash if you see tuplet.type == 'startStop'.

    commit 0ee87a2
    Author: Greg Chapman <[email protected]>
    Date:   Mon May 29 13:45:50 2023 -0700

        Lint.

    commit cdfa9bd
    Author: Greg Chapman <[email protected]>
    Date:   Mon May 29 13:29:09 2023 -0700

        Compare StaffLayout.staffLines (e.g. 5)  and staffLayout.staffSize (percent of normal).

commit ec533b1
Author: Greg Chapman <[email protected]>
Date:   Sun May 28 16:23:50 2023 -0700

    If diffing at Style level of detail, compare placement (above/below) of articulations and expressions.

commit d4c9182
Author: Greg Chapman <[email protected]>
Date:   Wed May 10 08:43:02 2023 -0700

    StaffGroup.symbol (brace, bracket, line, etc) should be considered style, not substance.

commit 58d226b
Author: Greg Chapman <[email protected]>
Date:   Sun May 7 12:17:33 2023 -0700

    Support comparison of StaffGroups.

    Squashed commit of the following:

    commit c0b7491
    Author: Greg Chapman <[email protected]>
    Date:   Sun May 7 10:21:12 2023 -0700

        AnnStaffGroups are in AllObjects (like AnnExtras)

    commit 9934e79
    Author: Greg Chapman <[email protected]>
    Date:   Tue May 2 15:20:56 2023 -0700

        Stop trying to differentiate between Part and PartStaff.  That's not a visible difference.

    commit 2ef16d0
    Author: Greg Chapman <[email protected]>
    Date:   Tue May 2 15:13:43 2023 -0700

        Support comparison of StaffGroups, and differentiate between Parts and PartStaffs.

commit 21edc39
Author: Greg Chapman <[email protected]>
Date:   Fri Apr 21 17:35:15 2023 -0700

    Update tests to include the new AnnNote parameter tuplet_info (tuplet number/bracket visibility and placement).

commit e17a228
Author: Greg Chapman <[email protected]>
Date:   Fri Apr 21 16:57:41 2023 -0700

    Update dependencies: python 3.10, converter21 3.0.0, music21 v9.1.

commit 921d547
Author: Greg Chapman <[email protected]>
Date:   Fri Apr 21 16:52:41 2023 -0700

    Squashed commit of the following:

    commit d897d39
    Author: Greg Chapman <[email protected]>
    Date:   Fri Apr 21 14:10:13 2023 -0700

        Fix a couple of introduced bugs.

    commit 75182dd
    Author: Greg Chapman <[email protected]>
    Date:   Fri Apr 21 13:57:53 2023 -0700

        A bunch of new typing for mypy to think about.

    commit 17dcd40
    Author: Greg Chapman <[email protected]>
    Date:   Fri Apr 21 12:43:20 2023 -0700

        Get pylint, mypy, flake8 all happy.

commit 237e41f
Author: Greg Chapman <[email protected]>
Date:   Tue Apr 18 15:24:07 2023 -0700

    Support comparison of ornament accidentals.
    Squashed commit of the following:

    commit d75e1a3
    Author: Greg Chapman <[email protected]>
    Date:   Sat Apr 15 17:21:42 2023 -0700

        Do proper annotation of InvertedMordent, too, not just Mordent.

    commit f97099a
    Author: Greg Chapman <[email protected]>
    Date:   Sat Apr 15 15:08:33 2023 -0700

        Add expression_to_string so we only see ornament accidental names if the accidental is visible.

    commit b45bf9f
    Author: Greg Chapman <[email protected]>
    Date:   Mon Mar 27 19:59:24 2023 -0700

        Undo some of that (match music21 changes).

    commit 4be373e
    Author: Greg Chapman <[email protected]>
    Date:   Sat Mar 25 16:32:24 2023 -0700

        Custom name for Turn/Mordent/Trill that includes accidentals, but only those with displayStatus == True.

commit b7835fd
Author: Greg Chapman <[email protected]>
Date:   Fri Mar 10 13:21:05 2023 -0800

    Support comparison of tuplet visibility/format/placement (placement only if diffing with style).

commit 143edd1
Author: Greg Chapman <[email protected]>
Date:   Sat Feb 11 10:35:28 2023 -0800

    Support comparison of page breaks and system breaks (but only if AllObjectsWithStyle is requested).

commit e0b5a9e
Author: Greg Chapman <[email protected]>
Date:   Fri Feb 10 13:03:49 2023 -0800

    Support for Ottavas (filling and transposition), and delayed turns.

    Squashed commit of the following:

    commit a00f0de
    Author: Greg Chapman <[email protected]>
    Date:   Tue Feb 7 14:59:56 2023 -0800

        Support delayed vs non-delayed turns.  No actual code changes necessary yet, since if music21 supports them, the turn.name will reflect the delay (and thus be incorporated into the diff).

    commit 3f53d2f
    Author: Greg Chapman <[email protected]>
    Date:   Fri Feb 3 13:19:37 2023 -0800

        Preserve accidental display status when transposing to written pitch.

    commit 888e3d8
    Author: Greg Chapman <[email protected]>
    Date:   Fri Jan 27 17:27:47 2023 -0800

        Catch up with music21 gregc/ottavaTransposeFix.

    commit 2058a72
    Author: Greg Chapman <[email protected]>
    Date:   Fri Jan 20 14:00:45 2023 -0800

        Keep up with music21 gregc/ottavaTransposeFix.

    commit 5b4ef4d
    Author: Greg Chapman <[email protected]>
    Date:   Fri Jan 20 13:27:03 2023 -0800

        Pick up a lost fix from main branch.

    commit 007b0ff
    Merge: 5f264da a0a2b0a
    Author: Greg Chapman <[email protected]>
    Date:   Fri Jan 20 10:37:25 2023 -0800

        Merge branch 'main' into gregc/ottavas

    commit 5f264da
    Author: Greg Chapman <[email protected]>
    Date:   Sun Jan 15 14:46:54 2023 -0800

        Use new converter21.register() API if it is there.

    commit 49c8212
    Author: Greg Chapman <[email protected]>
    Date:   Wed Dec 7 17:14:45 2022 -0800

        Before de-duping clefs from multiple voices, sort initialList by offset in measure, so potential duplicates are next to each other.

    commit 717d21f
    Author: Greg Chapman <[email protected]>
    Date:   Tue Dec 6 17:12:21 2022 -0800

        Ignore redundant clef changes.

    commit 7990f54
    Author: Greg Chapman <[email protected]>
    Date:   Mon Dec 5 15:09:42 2022 -0800

        Make ArpeggioMarkSpanner duration consistent when order of elements is different (0 will do).

    commit 000b9b7
    Author: Greg Chapman <[email protected]>
    Date:   Mon Dec 5 12:56:41 2022 -0800

        Lose the lint.

    commit b2749a4
    Author: Greg Chapman <[email protected]>
    Date:   Mon Dec 5 12:52:18 2022 -0800

        Instead of getFirst() to find primary location of spanner, for ArpeggioMarkSpanner use getHighestDiatonicNoteOrChord() so a difference in order of ArpeggioMarkSpanner elements is not seen as a difference worth noting.

    commit d865632
    Author: Greg Chapman <[email protected]>
    Date:   Sat Dec 3 12:46:04 2022 -0800

        Change the name of a M21Utils routine.

    commit 4944340
    Author: Greg Chapman <[email protected]>
    Date:   Fri Dec 2 17:41:07 2022 -0800

        Actually compare ottavas themselves.  Deal with it if music21 doesn't have fillIntermediateSpannedElements or inheritAccidentalDisplay.

    commit 30f00a0
    Author: Greg Chapman <[email protected]>
    Date:   Thu Dec 1 14:16:17 2022 -0800

        A couple fixes around inheritsAccidentalDisplay.

    commit 0014f92
    Author: Greg Chapman <[email protected]>
    Date:   Tue Nov 29 20:32:02 2022 -0800

        At start of annotation, transpose the entire score to written pitch.  This means we will be comparing apples with apples, both for transposing instruments, ottavas, and sometimes both at the same time.
  • Loading branch information
gregchapman-dev committed Nov 11, 2023
1 parent a0a2b0a commit c6c9afc
Show file tree
Hide file tree
Showing 25 changed files with 13,587 additions and 8,834 deletions.
51 changes: 51 additions & 0 deletions .flake8
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
[flake8]
ignore=
E127,
E128,
E301,
E302,
E303,
E501,
E722,
E731,
F401,
F405,
F821,
F841,
W391,
W503,

# E127, # over indented
# E128, # under indented
# E301, # 0 blank lines -- good test but something going wrong in new algorithm
# E302, # blank lines
# E303, # blank lines
# E501, # let pylint check line length
# E722, # let pylint check bare except
# E731, # do not assign a lambda
# F401, # let pylint check for imported but unused (wildcards and exports trigger)
# F405, # __all__ is okay to get from wildcard.
# F821, # let pylint check for undefined (del at end of module makes undefined)
# F841, # let pylint check for unused
# W391, # extra blank lines at end of file
# W503, # line break BEFORE binary operator

exclude=
.git,
__pycache__,
*.pyc,
ext,

# F403 = from module import *

per-file-ignores =
music21/chord/tables.py:E122,E124,E201,E202,E203,E221,E231,E241
music21/common/__init__.py:F403
music21/features/__init__.py:F403
music21/search/__init__.py:F403

max-line-length=100

inline-quotes = single
multiline-quotes = '''
docstring-quotes = '''
Loading

0 comments on commit c6c9afc

Please sign in to comment.