fix some code quality stuff

gregcusack · Nov 14, 2023 · 30c5741 · 30c5741
1 parent 90f8db8
commit 30c5741
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/k8s-cluster/src/kubernetes.rs b/k8s-cluster/src/kubernetes.rs
@@ -281,7 +281,7 @@ impl<'a> Kubernetes<'a> {
             ..Default::default()
         }];
 
-        if let Some(_) = &self.metrics {
+        if self.metrics.is_some() {
             env_var.push(self.get_metrics_env_var_secret())
         }
 
@@ -689,7 +689,7 @@ impl<'a> Kubernetes<'a> {
         label_selector: &BTreeMap<String, String>,
     ) -> Result<ReplicaSet, Box<dyn Error>> {
         let mut env_vars = self.set_non_bootstrap_environment_variables();
-        if let Some(_) = &self.metrics {
+        if self.metrics.is_some() {
             env_vars.push(self.get_metrics_env_var_secret())
         }
 
@@ -740,7 +740,7 @@ impl<'a> Kubernetes<'a> {
         label_selector: &BTreeMap<String, String>,
     ) -> Result<ReplicaSet, Box<dyn Error>> {
         let mut env_vars = self.set_non_bootstrap_environment_variables();
-        if let Some(_) = &self.metrics {
+        if self.metrics.is_some() {
             env_vars.push(self.get_metrics_env_var_secret())
         }
 

diff --git a/k8s-cluster/src/main.rs b/k8s-cluster/src/main.rs
@@ -790,7 +790,7 @@ async fn main() {
         .value_of("validator_image_name")
         .expect("Validator image name is required");
 
-    if let Some(_) = &kub_controller.metrics {
+    if kub_controller.metrics.is_some() {
         let metrics_secret = match kub_controller.create_metrics_secret() {
             Ok(secret) => secret,
             Err(err) => {