Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline initial #1491

Open
wants to merge 28 commits into
base: ctan
Choose a base branch
from

Commits on Feb 29, 2020

  1. Force rebuild of font database (including metrics) before building docs

    This appears to fix gregorio-project#1458.  Please test on other systems.
    rpspringuel committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    dfc3b55 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. Configuration menu
    Copy the full SHA
    22db9a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. Configuration menu
    Copy the full SHA
    45e40be View commit details
    Browse the repository at this point in the history
  2. Refactor gre@setinitial

    There was a whole bunch of repeated code on both branches of several if statements.  I've pulled that code out to reduce the if branches down to the absolute minimum.
    rpspringuel committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    7d77fde View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Remove gre@biginitial flag

    The gre@biginitial flag is redundant.  The same information can be found out by checking the value of gre@count@initiallines.
    rpspringuel committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    cc53d4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a5cd3f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63612e5 View commit details
    Browse the repository at this point in the history
  4. Fix typos

    rpspringuel committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3d2f93c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ba9ecb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Remove backup line adjustment

    I don't know what circumstances led to this backup being put into place, but I the whole test suite passes without it, so I don't think it's necessary anymore.
    rpspringuel committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0647b72 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. Configuration menu
    Copy the full SHA
    74592b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Rename gre@knownline to gre@count@knownline

    We want to identify gre@knownline as a count
    Also adding in debug messages associated with knownline to help with the identification of when lines are processed (eventually so we can adjust the staff lines at the right places).
    rpspringuel committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    a47d949 View commit details
    Browse the repository at this point in the history
  2. Stop double counting initialraise

    initialraise is already accounted for when \gre@dimen@temp@five is first established (line 402).  It doesn't need to be double counted for the large initial.
    rpspringuel committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    8a28943 View commit details
    Browse the repository at this point in the history
  3. Refactor initial height calculation

    This makes the height placement of the initial a function of the number of lines which wrap it rather than a fixed amount.  It doesn't change anything for the 1 or 2 line initials, just makes it so that when 3 (or more) line initials are implemented, this calculation will be ready for them.
    rpspringuel committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    aaa54b6 View commit details
    Browse the repository at this point in the history
  4. Account for number of staff lines in initial placement

    As staff lines with fewer or more than 4 lines have different heights so the position of the initial needs to be adapted as appropriate.  This change fixes the new tests introduced in gregorio-project/gregorio-test@8713c85 (and amended in gregorio-project/gregorio-test@d8829fc).
    rpspringuel committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    096fcfa View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Use existing staffheight

    We already calculate the staffheight and don't need to calculate it again here.
    Note: making this change reveals an off-by-one error in the manual calculation: there was an extra interstafflinespace.  The number of spaces between the lines is one less than the number of lines: line-space-line
    rpspringuel committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    8106316 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4358ab View commit details
    Browse the repository at this point in the history
  3. Refactoring to make more use of staffheight where appropriate

    In line with 8106316 these are calculations which should have been using staffheight but weren't.
    Also found another off-by-one error in the placement of the above lines text.  This was hidden by the fact that the size of the lyrics wasn't being taken into account.
    The change in gregoriotex-signs.tex did not have an off-by-one error because we're drawing the ledger line exactly one interstafflinespace above the staff.  Hence, when we change to using staffheight, we still need one more factor of interstafflinespace
    rpspringuel committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    522774a View commit details
    Browse the repository at this point in the history
  4. Refactor

    A pretty basic simplification of a calculation.
    rpspringuel committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    53fc493 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Configuration menu
    Copy the full SHA
    4ff485e View commit details
    Browse the repository at this point in the history
  2. Add semi-manual mode for determining where initials end

    In semi-manual mode, only the last line of the lines wrapping the initial needs to be indicated manually (as opposed to the manual mode, where each line must be indicated).
    rpspringuel committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    db016df View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2021

  1. Configuration menu
    Copy the full SHA
    d242e0d View commit details
    Browse the repository at this point in the history
  2. Find GNU sed

    Accidentally removed this when merging other branches in.
    rpspringuel committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    a24036b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Convert the initial ending style flag to a boolean

    Since there are only two possible states, the code can be simplified if this flag is a boolean.
    rpspringuel committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    dfab895 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8fa392 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4393a2d View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    01b6dc2 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Trying to lower the initial to match the right baseline when dealing …

    …with multi-line initials
    rpspringuel committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    39d9496 View commit details
    Browse the repository at this point in the history