remove uneeded invariant

gregtatcam · Jan 17, 2024 · 1f87af0 · 1f87af0
1 parent ded84f8
commit 1f87af0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/src/ripple/app/tx/impl/InvariantCheck.cpp b/src/ripple/app/tx/impl/InvariantCheck.cpp
@@ -815,10 +815,6 @@ ValidMPTIssuance::visitEntry(
             mptIssuancesDeleted_++;
         else if (!before)
             mptIssuancesCreated_++;
-
-        if ((*after)[sfOutstandingAmount] >
-            (*after)[~sfMaximumAmount].value_or(maxMPTokenAmount))
-            amountExceededMax_ = true;
     }
 
     if (after && after->getType() == ltMPTOKEN)
@@ -966,14 +962,9 @@ ValidMPTIssuance::finalize(
     {
         JLOG(j.fatal()) << "Invariant failed: a MPToken was deleted";
     }
-    else if (amountExceededMax_)
-    {
-        JLOG(j.fatal())
-            << "Invariant failed: OutstandingAmount exceeded MaximumAmount";
-    }
 
     return mptIssuancesCreated_ == 0 && mptIssuancesDeleted_ == 0 &&
-        mptokensCreated_ == 0 && mptokensDeleted_ == 0 && !amountExceededMax_;
+        mptokensCreated_ == 0 && mptokensDeleted_ == 0;
 }
 
 }  // namespace ripple
diff --git a/src/ripple/app/tx/impl/InvariantCheck.h b/src/ripple/app/tx/impl/InvariantCheck.h
@@ -426,8 +426,6 @@ class ValidMPTIssuance
     std::uint32_t mptokensCreated_ = 0;
     std::uint32_t mptokensDeleted_ = 0;
 
-    bool amountExceededMax_ = false;
-
 public:
     void
     visitEntry(