-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tecMPT_ISSUANCE_NOT_FOUND code #33
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1875,7 +1875,7 @@ rippleCredit( | |
view.update(sle); | ||
} | ||
else | ||
return tecINTERNAL; | ||
return tecMPT_ISSUANCE_NOT_FOUND; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If a sender is not the issuer, need to check if mpt issuance doesn't exist. I.e., if it doesn't exist then the error is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you clarify? The code currently does what you have described. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If a sender is not the issuer then we are getting MPToken object. If this object doesn't exist then There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i moved the check to the start of function |
||
} | ||
else | ||
{ | ||
|
@@ -1914,7 +1914,7 @@ rippleCredit( | |
return tecINSUFFICIENT_FUNDS; | ||
} | ||
else | ||
return tecINTERNAL; | ||
return tecMPT_ISSUANCE_NOT_FOUND; | ||
} | ||
else | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to authorize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the test as it is, I added another test case where the holder didn't authorize