Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed mptHolders #43

Merged
merged 2 commits into from
Oct 18, 2024
Merged

removed mptHolders #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f0ab9c
removed unused declarations
shawnxie999 Oct 18, 2024
78b19df
comments
shawnxie999 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/xrpld/rpc/MPTokenIssuanceID.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ namespace ripple {

namespace RPC {

/**
Add a `mpt_issuance_id` field to the `meta` input/output parameter.
The field is only added to successful MPTokenIssuanceCreate transactions.
The mpt_issuance_id is parsed from the sequence and the issuer in the
MPTokenIssuance object.

@{
*/
bool
canHaveMPTokenIssuanceID(
std::shared_ptr<STTx const> const& serializedTx,
Expand Down
4 changes: 2 additions & 2 deletions src/xrpld/rpc/detail/MPTokenIssuanceID.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//------------------------------------------------------------------------------
/*
This file is part of rippled: https://github.com/ripple/rippled
Copyright (c) 2023 Ripple Labs Inc.
Copyright (c) 2024 Ripple Labs Inc.

Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
Expand Down Expand Up @@ -75,7 +75,7 @@ insertMPTokenIssuanceID(
return;

std::optional<uint192> result = getIDFromCreatedIssuance(transactionMeta);
if (result.has_value())
if (result)
response[jss::mpt_issuance_id] = to_string(result.value());
}

Expand Down
3 changes: 0 additions & 3 deletions src/xrpld/rpc/detail/Tuning.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ static LimitRange constexpr accountNFTokens = {20, 100, 400};
/** Limits for the nft_buy_offers & nft_sell_offers commands. */
static LimitRange constexpr nftOffers = {50, 250, 500};

/** Limits for the nft_buy_offers & nft_sell_offers commands. */
static LimitRange constexpr mptHolders = {10, 200, 400};

static int constexpr defaultAutoFillFeeMultiplier = 10;
static int constexpr defaultAutoFillFeeDivisor = 1;
static int constexpr maxPathfindsInProgress = 2;
Expand Down
2 changes: 0 additions & 2 deletions src/xrpld/rpc/handlers/Handlers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ doBlackList(RPC::JsonContext&);
Json::Value
doCanDelete(RPC::JsonContext&);
Json::Value
doMPTHolders(RPC::JsonContext&);
Json::Value
doChannelAuthorize(RPC::JsonContext&);
Json::Value
doChannelVerify(RPC::JsonContext&);
Expand Down
Loading