Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPTTester class to streamline MPToken unit-tests #9

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

gregtatcam
Copy link
Owner

No description provided.

std::unordered_map<std::string, AccountP> const holders_;
std::optional<std::uint32_t> sequence_;
std::optional<uint192> id_;
std::optional<uint256> issuanceID_;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be called something like issuanceKey_

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And id_ should be issuanceID_, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think it matters...

Copy link

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor!

@gregtatcam gregtatcam merged commit f8d5397 into cftoken-direct-pay Jan 10, 2024
4 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants