Account activity loading enhancement #334
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying 2nicove with
|
| Latest commit: |
e64cca2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5790cf7.unicove2.pages.dev |
| Branch Preview URL: | https://account-activity-loading.unicove2.pages.dev |
stale while revalidate should be longer than max age otherwise it doesn't get triggered
aaroncox
approved these changes
Feb 26, 2025
| const headers = getCacheHeaders(5); | ||
| const start = params.start === '0' ? 1 : Number(params.start); | ||
|
|
||
| // Aggressively cache older activity |
There was a problem hiding this comment.
We can't do this, because older activity shifts in time and the results aren't in the same sequence because its in descending order.
If the initial page shows records 99 through 90 (walking back in time), and page 2 shows 89 to 80 - then if a new entry is added to the front, record 90 would end up on page 2. If page 2 is cached, that record won't show.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
account/overviewpage will prefetch the data for the initialaccount/activitypage loadaccount/activitypage will prefetch the data for the next pageaccount/activitypage (a.k.a. the most recent data) is cached for 5s while older activity beyond the first page is cached for 3600s (1 hour)