Add mutualized api functions #455

Meklo · 2024-05-23T08:49:54Z

Removes the FilterContext, replaced by the following functions for API calls related to fetching directory data :

fetchRootFolders
fetchDirectoryContent
fetchDirectoryElementPath
elementExists
fetchElementsInfos

The following method used to retrieve the application metadata :

fetchAppsAndUrls (renamed to fetchAppsMetadata)

Also:

downloadZipFile (renamed to downloadFile)

Also adds common functions needed for data fetching mechanisms

backendFetch
backendFetchJson
backendFetchFile
backendFetchText

src/hooks/predefined-properties-hook.ts

src/services/apps-metadata.ts

src/services/directory.ts

Tristan-WorkGH

part 1

src/services/apps-metadata.ts

src/index.ts

src/services/utils.ts

src/services/explore.ts

src/services/directory.ts

src/services/metadata.ts

src/services/directory.ts

Tristan-WorkGH

part2

Have you look to a more update version of utilities function for rest base from gridadmin ?

Tristan-WorkGH · 2024-05-27T16:46:24Z

src/services/apps-metadata.ts

+
+export type Url = string | URL;
+
+export function fetchEnv() {


Type existing at https://github.com/gridsuite/gridadmin-app/blob/664aee0be5529417fa7a1920fbcbeb750cd0fc5e/src/services/apps-metadata.ts#L11-L23

Issue is, it can't resolve ../../public/env.json during compilation in commons-ui

Yes, that was to not have to manage manually the type definition manually.
You just remove the link to the file in the definition and it's good.

src/services/index.ts

src/services/metadata.ts

src/services/utils.ts

src/services/explore.ts

src/services/utils.ts

src/services/directory.ts

Tristan-WorkGH

part3

Tristan-WorkGH · 2024-05-27T17:48:21Z

src/services/explore.ts

+    const idsParams = getRequestParamFromList(
+        ids.filter((id) => id), // filter falsy elements
+        'ids'
+    );
+
+    const equipmentTypesParams = getRequestParamFromList(
+        equipmentTypes,
+        'equipmentTypes'
+    );
+
+    const elementTypesParams = getRequestParamFromList(
+        elementTypes,
+        'elementTypes'
+    );
+
+    const urlSearchParams = new URLSearchParams([
+        ...idsParams,
+        ...equipmentTypesParams,
+        ...elementTypesParams,
+    ]).toString();


There is a problem here because getRequestParamFromList() return an URLSearchParams...

Based on https://stackoverflow.com/questions/45126076/how-can-i-combine-two-urlsearchparams
It seems to be possible to combine them this way : new URLSearchParams({ ...Object.fromEntries(params1), ...Object.fromEntries(params2) });

Nevermind, it broke the function

Would you prefer instantiating only one URLSearchParams or a better system to merge multiple URLSearchParams into one ?

Tristan-WorkGH · 2024-05-27T18:10:42Z

src/components/DirectoryItemSelector/directory-item-selector.tsx

+                .catch((error) => {
+                    console.warn(


only a console log?

How so ? Since it's in a catch bock I'd reckon a warn is warranted
EDIT : Ah I misunderstood, yea this far the error is only logged and not displayed in a snackbar

src/index.ts

src/services/metadata.ts

src/services/apps-metadata.ts

src/services/directory.ts

src/services/utils.ts

src/services/metadata.ts

src/services/utils.ts

Tristan-WorkGH · 2024-05-29T09:12:37Z

src/utils/ElementAttributes.ts

If it's only to define a type, maybe not in src/utils/ but in src/types/ for example.

~~Also is it meant to be use multiple time or only once (actual case)? If the later I would move it where it's used.~~

src/services/utils.ts

dbraquart

code: ok
tests: to be continued

Tristan-WorkGH

now assigned to me

* `VITE_*` variables are kept in finale build * URLs used by fetchers are based on app base to be permissive to a base not at root

Found a way to resolve import namespace not extendable while keeping ftechers grouped by service/server, and also managing user token_id problem.

All changes requested were resolved

Meklo requested review from Tristan-WorkGH and flomillot May 24, 2024 08:52

Tristan-WorkGH assigned Meklo May 24, 2024

flomillot requested changes May 24, 2024

View reviewed changes

src/hooks/predefined-properties-hook.ts Outdated Show resolved Hide resolved

src/services/apps-metadata.ts Outdated Show resolved Hide resolved

src/services/directory.ts Show resolved Hide resolved

Tristan-WorkGH requested changes May 24, 2024

View reviewed changes

Meklo requested review from flomillot and Tristan-WorkGH May 27, 2024 14:25

flomillot reviewed May 27, 2024

View reviewed changes

src/services/metadata.ts Outdated Show resolved Hide resolved

src/services/directory.ts Outdated Show resolved Hide resolved

src/services/directory.ts Outdated Show resolved Hide resolved

src/services/directory.ts Show resolved Hide resolved

Tristan-WorkGH requested changes May 27, 2024

View reviewed changes

Meklo requested review from flomillot and Tristan-WorkGH May 28, 2024 15:45

flomillot reviewed May 28, 2024

View reviewed changes

flomillot previously requested changes May 28, 2024

View reviewed changes

src/services/utils.ts Outdated Show resolved Hide resolved

src/services/utils.ts Outdated Show resolved Hide resolved

src/services/utils.ts Outdated Show resolved Hide resolved

Tristan-WorkGH reviewed May 29, 2024

View reviewed changes

flomillot mentioned this pull request May 29, 2024

Remove Filter context #460

Merged

Meklo changed the title ~~Add directory api~~ Add mutualized api functions Jun 7, 2024

dbraquart self-requested a review July 3, 2024 14:14

dbraquart reviewed Jul 4, 2024

View reviewed changes

Tristan-WorkGH approved these changes Jul 5, 2024

View reviewed changes

Tristan-WorkGH added 10 commits July 11, 2024 17:40

rebase: Add common API utility functions

e594765

rebase: Refactor existing fetchers

8c7784c

Rework API variables

6a1dc70

* `VITE_*` variables are kept in finale build * URLs used by fetchers are based on app base to be permissive to a base not at root

rebase: Add new common fetchers

547319e

rebase: ElementExists definition from filters

b9c636c

refactor fetchers access

8ec3572

Merge remote-tracking branch 'origin/main' into feat/add_directory_api

47e07e4

Move non remote fetcher to dedicated file

7f73212

Add fetchers for AboutDialog

c4989e9

Resolve problem of _API_GATEWAY & _WS_GATEWAY variables for CRA apps

de3df20

Tristan-WorkGH added 7 commits July 23, 2024 16:07

Add config server common fetchers

e3a16de

more simple use of AdboudDialog to get modules ... for us

8e7d9a0

better than casting

a1930f9

Migrate common local-storage parameters

8b97ce0

Merge remote-tracking branch 'origin/main' into feat/add_directory_api

a0262f7

Resolve fetchers namespace problem

eb1452c

Found a way to resolve import namespace not extendable while keeping ftechers grouped by service/server, and also managing user token_id problem.

Add user-admin user validation for auth

571416f

Tristan-WorkGH force-pushed the feat/add_directory_api branch from 15fd221 to 571416f Compare July 25, 2024 08:51

Tristan-WorkGH added 4 commits July 26, 2024 15:00

Merge remote-tracking branch 'origin/main' into feat/add_directory_api

1246f1a

fix bad import + cyclic dependencies

bf87e31

Merge branch 'main' into feat/add_directory_api

e51a054

pick 120

6e3ab89

Tristan-WorkGH force-pushed the feat/add_directory_api branch from 5c232c8 to b4015aa Compare August 6, 2024 21:19

Merge remote-tracking branch 'origin/main' into feat/add_directory_api

3d0d71f

Tristan-WorkGH force-pushed the feat/add_directory_api branch from b4015aa to 3d0d71f Compare August 6, 2024 21:28

SlimaneAmar requested a review from flomillot August 7, 2024 06:18

Tristan-WorkGH added 2 commits August 12, 2024 12:37

mutualize fixes

d33b8bb

mutualize fixes & mutualize some fetchers

4df8b34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mutualized api functions #455

Add mutualized api functions #455

Meklo commented May 23, 2024 •

edited by dbraquart

Loading

Tristan-WorkGH left a comment

Tristan-WorkGH left a comment •

edited

Loading

Tristan-WorkGH May 27, 2024

Meklo May 28, 2024

Tristan-WorkGH May 29, 2024

Tristan-WorkGH left a comment

Tristan-WorkGH May 27, 2024

Meklo May 28, 2024

Meklo May 28, 2024

Meklo May 28, 2024

Tristan-WorkGH May 27, 2024

Meklo May 28, 2024 •

edited

Loading

Tristan-WorkGH May 29, 2024 •

edited

Loading

dbraquart left a comment

Tristan-WorkGH left a comment

Add mutualized api functions #455

Are you sure you want to change the base?

Add mutualized api functions #455

Conversation

Meklo commented May 23, 2024 • edited by dbraquart Loading

Tristan-WorkGH left a comment

Choose a reason for hiding this comment

Tristan-WorkGH left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tristan-WorkGH left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Meklo May 28, 2024 • edited Loading

Choose a reason for hiding this comment

Tristan-WorkGH May 29, 2024 • edited Loading

Choose a reason for hiding this comment

dbraquart left a comment

Choose a reason for hiding this comment

Tristan-WorkGH left a comment

Choose a reason for hiding this comment

Meklo commented May 23, 2024 •

edited by dbraquart

Loading

Tristan-WorkGH left a comment •

edited

Loading

Meklo May 28, 2024 •

edited

Loading

Tristan-WorkGH May 29, 2024 •

edited

Loading