fix(element-search): remove freesolo and improve typing #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
…s-ui into jorism/remove-free-solo
klesaulnier
approved these changes
May 23, 2024
Signed-off-by: Joris Mancini <[email protected]>
sBouzols
reviewed
May 23, 2024
| @@ -54,8 +53,8 @@ const ElementSearchDialog = (props: ElementSearchDialogProps) => { | |||
|
|
|||
| const displayedValue = useMemo(() => { | |||
| return searchTermDisabled || searchTermDisableReason | |||
| ? searchTermDisableReason | |||
| : searchTerm; | |||
| ? searchTermDisableReason ?? 'search disabled' | |||
There was a problem hiding this comment.
manage translation for this default value
sBouzols
reviewed
May 23, 2024
| // we don't want to change "searchTerm" when clicking a result | ||
| if (!searchTermDisabled && reason !== 'reset') { | ||
| onInputChange={(_event, value) => { | ||
| if (!searchTermDisabled) { |
There was a problem hiding this comment.
must restore reason to avoid calling onSearchTermChange when selecting an option. Otherwise it will fetch serach one more time
TheMaskedTurtle
force-pushed
the
jorism/remove-free-solo
branch
from
5f5748a to
ef23da5
Compare
capyq
requested changes
Aug 23, 2024
Comment on lines
+56
to
+61
| ? searchTermDisableReason ?? | ||
| intl.formatMessage({ | ||
| id: 'element_search/searchDisabled', | ||
| }) | ||
| : searchTerm ?? ''; | ||
| }, [searchTermDisabled, searchTermDisableReason, intl, searchTerm]); |
There was a problem hiding this comment.
This is usually not a good pratice to add complexity to ternary.
you probably need to change to if/else statement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freesolo is not the wished behavior for the element search bar so we can remove it, it simplifies component typing.