WIP: Fix null exception in directory item selector #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined-previousNode
AAJELLAL
reviewed
Aug 21, 2024
capyq
requested changes
Aug 23, 2024
| @@ -77,7 +77,7 @@ function updatedTree(prevRoots: any[], prevMap: any, nodeId: UUID | null, childr | |||
| return pn; | |||
| } | |||
| if (pn.parentUuid !== nodeId) { | |||
| console.warn(`reparent ${pn.parentUuid} -> ${nodeId}`); | |||
| console.warn(`reparent ${pn?.parentUuid} -> ${nodeId}`); | |||
There was a problem hiding this comment.
I don't understant how it fix null exception.
if your optional chainning is the fix, that mean that "pn" is undefined.
and line 79 if "pn" is undefined you will get the same null exception.
line 68 if "pn" is undefined we return a value, so line 80 pn couldn't be undefined.
There was a problem hiding this comment.
I apologize for the confusion. The title of the pull request was a mistake, and the bug is not resolved yet. I will investigate further to address the root cause of the issue.
in fact i think the issue is related to a data migration . it's not reproducible
jamal-khey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the directory item selector's
updatedTreefunction could throw a null exception.this issu happen in modification by formula , when selecting a filter and then moving it to another directory. when the user re-click on the chip of the filter , the derictory can not be selected