Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete criteria filter code + modify tests #66

Merged
merged 6 commits into from
Dec 18, 2024
Merged

delete criteria filter code + modify tests #66

merged 6 commits into from
Dec 18, 2024

Conversation

basseche
Copy link
Contributor

@basseche basseche commented Dec 9, 2024 •
edited
Loading

Lib used by :

GridSuite/dynamic-mapping-server/pom.xml
GridSuite/dynamic-simulation-server/pom.xml
GridSuite/network-modification/pom.xml
GridSuite/filter-server/pom.xml
GridSuite/loadflow-server/pom.xml

@basseche basseche self-assigned this Dec 9, 2024
@Mathieu-Deharbe Mathieu-Deharbe requested review from Mathieu-Deharbe and removed request for EtienneLt December 17, 2024 14:01
Mathieu-Deharbe
Mathieu-Deharbe reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here :

public enum FilterType {
    SCRIPT,
    CRITERIA,
    IDENTIFIER_LIST,
    EXPERT,
}

You can probably remove CRITERIA,.

I tested without it and didn't encounter any problem.

Edit : Done.

src/test/java/org/gridsuite/filter/utils/FiltersUtilsTest.java Outdated Show resolved Hide resolved
@basseche basseche force-pushed the delete-criteria-filter branch from 70de89a to 2e76f01 Compare December 18, 2024 10:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thangqp thangqp self-requested a review December 18, 2024 10:56
@basseche basseche merged commit 0dea81f into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathieu-Deharbe Mathieu-Deharbe Mathieu-Deharbe approved these changes

@thangqp thangqp thangqp approved these changes

@ghazwarhili ghazwarhili Awaiting requested review from ghazwarhili

Assignees

@basseche basseche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basseche @thangqp @Mathieu-Deharbe