Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutualized api functions #33

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Meklo
Copy link
Contributor

@Meklo Meklo commented Jun 7, 2024

No description provided.

@Meklo Meklo changed the title Remove mutualized ws functions Remove mutualized functions Jun 7, 2024
@Meklo Meklo changed the title Remove mutualized functions Remove mutualized api functions Jun 7, 2024
@Meklo Meklo requested a review from Tristan-WorkGH June 18, 2024 14:20
@Meklo Meklo self-assigned this Jun 18, 2024
@dbraquart dbraquart self-requested a review July 4, 2024 08:34
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: 3 functions to remove (use commons-ui instead)
tests: not done

@@ -5,7 +5,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchRootFolders, fetchDirectoryContent, should be removed from here

@@ -5,7 +5,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchElementsInfos should be removed from here

@Tristan-WorkGH Tristan-WorkGH removed their request for review July 26, 2024 09:58
@Tristan-WorkGH Tristan-WorkGH force-pushed the feat/remove_fetch_utils branch from 07c7cea to d2bc586 Compare July 26, 2024 09:59
@Tristan-WorkGH Tristan-WorkGH requested a review from dbraquart July 26, 2024 10:03
@Tristan-WorkGH Tristan-WorkGH force-pushed the feat/remove_fetch_utils branch from 637cf5a to 8962658 Compare August 12, 2024 10:38
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants