Migrate codebase to typescript #57
Conversation
TODO: need to update usage of Redux with Toolkit
Tristan-WorkGH
added
documentation
Tristan-WorkGH
requested review from
SlimaneAmar and
flomillot
and removed request for
achour94
| @@ -4,6 +4,10 @@ | |||
| "license": "MPL-2.0", | |||
| "homepage": ".", | |||
| "private": true, | |||
| "engines": { | |||
There was a problem hiding this comment.
I already tried to add this when I arrived long time ago but apparently we should not, so I think you can remove this part
There was a problem hiding this comment.
why? I'm interested of the reason.
There was a problem hiding this comment.
Honestly I don't know, I don't remember.
Cf these PR never merged :
gridsuite/gridstudy-app#814
gridsuite/gridstudy-app#766
There was a problem hiding this comment.
Explanation : powsybl/powsybl-network-viewer#29 (comment)
There was a problem hiding this comment.
I think we can discuss about it, but for a lot of them you define types that don't bring any value. Using typescript, you must first let it infer what it can infer especially for function return types, then add specific types when it brings value and readability to our code. It is a bad practice to use types of types that comes for other libs with a lot of templating and all, we must define types that make sense for us and for our code, and it's compiler role to make sure that our defined types match to the signature of functions we call.
Tristan-WorkGH
force-pushed
the
migrate_ts
branch
from
4e22d6e to
6f03f01
Compare
Co-authored-by: Joris Mancini <[email protected]> Signed-off-by: Tristan Chuine <[email protected]>
Tristan-WorkGH
force-pushed
the
migrate_ts
branch
from
6f03f01 to
1055744
Compare
Tristan-WorkGH
force-pushed
the
migrate_ts
branch
from
24fa8b2 to
83ca55e
Compare
No description provided.