Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit set control in the creation line network modification #2390

Merged
merged 182 commits into from
Feb 10, 2025
Merged

limit set control in the creation line network modification #2390

merged 182 commits into from
Feb 10, 2025

Conversation

Mathieu-Deharbe
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe commented Nov 13, 2024 •
edited
Loading

No description provided.

Mathieu-Deharbe and others added 9 commits November 13, 2024 13:49
@Mathieu-Deharbe
ceration line full width interface
5ee5262 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
restructuration
cc7a7e2 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
reduce IST field size
37db5c8 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
paper draft
89ce316 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
draft remove checkboxes and restructures
2f4a171 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
minRowsNumber
8e6a066 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
extract LimitsSidePane
39bf494 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
corrects import
e1d473b 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
Merge branch 'main' into limit-sets-ui
f8d0f83
@Mathieu-Deharbe Mathieu-Deharbe changed the title creation line full width interface limit set control in the creation line network modification Nov 20, 2024
Mathieu-Deharbe and others added 20 commits November 22, 2024 16:30
@Mathieu-Deharbe
draft : conversion to complete limit set data
9330077 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
Merge branch 'main' into limit-sets-ui
a260459
@Mathieu-Deharbe
refacto permanentCurrentLimitField
3e859e8 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
refacto useFieldArrayOutputTemporaryLimits
016e89e 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
refacto SelectedOperationalLimitGroup
80ae988 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
fill limit sets available in SelectedOperationalLimitGroup
e2e4955 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
transfer code logic to limit-side-pane
0f445ff 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
transfer isTemporaryLimitModified code logic to limit-side-pane
f7d2f60 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
draft LimitsPane to typescript
e8f1060 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
draft tab system + correct bug
649d85f 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
nettoyage
38821d9 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
nettoyage
79d0ae0 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
limitSets as strings
260012c 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
reactive limit lists
1ec614f 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
cleaning
8964f40 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
SelectedOperationalLimitGroup to typescript
9f4d98d 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
prettier
88645ec 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
meilleur menu Tabs
6eee9c9 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
rollback menu Tabs + draft of the limit set modification icon
843c547 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
Merge branch 'main' into limit-sets-ui
853ba91
Mathieu-Deharbe and others added 3 commits February 5, 2025 12:55
@Mathieu-Deharbe
Merge remote-tracking branch 'origin/limit-sets-ui' into limit-sets-ui
07d9dd0 
# Conflicts:
#	src/components/dialogs/limits/copy-limits.tsx
@Mathieu-Deharbe
Merge branch 'main' into limit-sets-ui
a91685e
@Mathieu-Deharbe
cleans getPreviousValue
c4c3ad7 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
reformat
1186175 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
clean import
0a59818 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@basseche

This comment was marked as outdated.

Sign in to view
@Mathieu-Deharbe

This comment was marked as outdated.

Sign in to view
@basseche

This comment was marked as off-topic.

Sign in to view
Mathieu-Deharbe and others added 3 commits February 5, 2025 17:40
@Mathieu-Deharbe
editingTabIndex as pure number + unique key
7388542 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
removed copy limits
c2c3314 
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@ghazwarhili
Merge branch 'main' into limit-sets-ui
ffa10ce
ghazwarhili
ghazwarhili approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@ghazwarhili ghazwarhili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the code still needs a lot of work and several things need to be properly redone, since it's a big task and has been dragging on for a while, I approve merging it now, and we will improve it in other PRs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
2.9% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

@Mathieu-Deharbe Mathieu-Deharbe merged commit 8303184 into main Feb 10, 2025
5 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the limit-sets-ui branch February 10, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennehomer etiennehomer

@github-actions github-actions[bot]

@ghazwarhili ghazwarhili

@basseche basseche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mathieu-Deharbe @basseche @ghazwarhili @etiennehomer