Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The developer mode is accessible from the user settings menu. #2532

Merged
merged 33 commits into from
Feb 6, 2025
Merged

The developer mode is accessible from the user settings menu. #2532

merged 33 commits into from
Feb 6, 2025
+0 −73

Conversation

EstherDarkish
Copy link
Contributor

@EstherDarkish EstherDarkish commented Jan 28, 2025 •
edited
Loading

No description provided.

BOUTIER Charly and others added 4 commits January 28, 2025 11:53
The developer mode is accessible from the user settings menu.
dccc091 
Still needs to clean the existing parameter form.

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Cleaning the old advanced parameter tab.
2ca73ec 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish
Merge branch 'main' into developermode_dialog
f2b23af
code cleaning
5003b22 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
AAJELLAL
AAJELLAL reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@AAJELLAL AAJELLAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The synchronization issue between two tabs is still present in Gridexplore and Study.

EstherDarkish and others added 2 commits January 31, 2025 16:59
@EstherDarkish
Merge branch 'main' into developermode_dialog
9596f4f
PR Review
d5b9850 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
sBouzols
sBouzols reviewed Feb 4, 2025
View reviewed changes
Remove the useless debounce in useParameterState
17e4e9f 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
BOUTIER Charly and others added 9 commits February 4, 2025 11:45
Merge branch 'remove_parameter_debounce' into developermode_dialog
8db02e4 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>

# Conflicts:
#	src/components/dialogs/parameters/parameters.tsx
@EstherDarkish
Merge branch 'main' into developermode_dialog
f4c357b
PR Review
64c7aad 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish
Merge branch 'main' into developermode_dialog
9c4083c
Moved the user settings dialog in commons-ui. See gridsuite/commons-u…
37ace63 
…i#682

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Code cleaning
746f2cd 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish
Merge branch 'main' into developermode_dialog
3475fb6
@EstherDarkish
Merge branch 'main' into developermode_dialog
abcf1eb
@AAJELLAL
Merge branch 'main' into developermode_dialog
2625f7c
AAJELLAL
AAJELLAL approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@AAJELLAL AAJELLAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and test are ok. synchro between tabs is ok

sBouzols
sBouzols approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@sBouzols sBouzols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review OK
Tests OK
Console warning check OK

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@EstherDarkish EstherDarkish merged commit 168860c into main Feb 6, 2025
5 checks passed
@EstherDarkish EstherDarkish deleted the developermode_dialog branch February 6, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sBouzols sBouzols

@AAJELLAL AAJELLAL

@souissimai souissimai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EstherDarkish @sBouzols @AAJELLAL @souissimai