Clean up Report management #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayoub LABIDI <[email protected]>
dbraquart
reviewed
Sep 12, 2024
Comment on lines
1671
to
1672
| List<Report> subReporters = List.of(reportService.getReport(reportUuid, nodeUuid.toString(), severityLevels)); | ||
| return subReporters.isEmpty() ? subReporters : List.of(subReporters.get(subReporters.size() - 1)); |
There was a problem hiding this comment.
Suggested change
| List<Report> subReporters = List.of(reportService.getReport(reportUuid, nodeUuid.toString(), severityLevels)); | |
| return subReporters.isEmpty() ? subReporters : List.of(subReporters.get(subReporters.size() - 1)); | |
| return List.of(reportService.getReport(reportUuid, nodeUuid.toString(), severityLevels)); |
can be simplified
ayolab
force-pushed
the
ayolab/clean-up-report-management
branch
from
bdf361b to
24787d8
Compare
Signed-off-by: Ayoub LABIDI <[email protected]>
Signed-off-by: Ayoub LABIDI <[email protected]>
Signed-off-by: Ayoub LABIDI <[email protected]>
ayolab
force-pushed
the
ayolab/clean-up-report-management
branch
from
1ae53c6 to
3421f31
Compare
Signed-off-by: Ayoub LABIDI <[email protected]>
Signed-off-by: Ayoub LABIDI <[email protected]>
|
Signed-off-by: Ayoub LABIDI <[email protected]>
ayolab
force-pushed
the
ayolab/clean-up-report-management
branch
from
aa078c8 to
0a791da
Compare
Signed-off-by: Ayoub LABIDI <[email protected]>
ayolab
force-pushed
the
ayolab/clean-up-report-management
branch
from
d26af43 to
f4bd532
Compare
TheMaskedTurtle
requested changes
Sep 23, 2024
src/main/java/org/gridsuite/study/server/service/StudyService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/StudyService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/StudyService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/StudyService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/NetworkModificationTreeService.java
Outdated
Show resolved
Hide resolved
...idsuite/study/server/networkmodificationtree/NetworkModificationNodeInfoRepositoryProxy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/NetworkModificationTreeService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/NetworkModificationTreeService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/study/server/service/NetworkModificationTreeService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ayoub LABIDI <[email protected]>
TheMaskedTurtle
approved these changes
Sep 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.