[Dynamic Security Analysis] Add endpoints for managing parameters and running computation #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
basseche
reviewed
Feb 6, 2025
basseche
reviewed
Feb 6, 2025
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
basseche
reviewed
Feb 7, 2025
| String endPointUrl = buildEndPointUrl(getBaseUri(), DYNAMIC_SECURITY_ANALYSIS_API_VERSION, DYNAMIC_SECURITY_ANALYSIS_END_POINT_PARAMETER); | ||
|
|
||
| String url = UriComponentsBuilder | ||
| .fromHttpUrl(endPointUrl + "{uuid}") |
There was a problem hiding this comment.
this literal is used 3 times in the code. Define a constant instead.
basseche
reviewed
Feb 7, 2025
| } | ||
|
|
||
| public void updateProvider(UUID parametersUuid, String provider) { | ||
| Objects.requireNonNull(parametersUuid); |
There was a problem hiding this comment.
you can use NonNull annotation instead of this kind of check :
public void updateProvider(@NonNull UUID parametersUuid, @NonNull String provider) { ...}
basseche
reviewed
Feb 7, 2025
| } | ||
|
|
||
| public UUID createParameters(String parametersInfos) { | ||
| Objects.requireNonNull(parametersInfos); |
basseche
reviewed
Feb 7, 2025
| Objects.requireNonNull(parametersUuid); | ||
| Objects.requireNonNull(provider); | ||
|
|
||
| String endPointUrl = buildEndPointUrl(getBaseUri(), DYNAMIC_SECURITY_ANALYSIS_API_VERSION, DYNAMIC_SECURITY_ANALYSIS_END_POINT_PARAMETER); |
There was a problem hiding this comment.
this function is called in almost every function, maybe put it in class member attribute :
endpointUrl for example or class member function to avoid code duplication.
basseche
reviewed
Feb 7, 2025
| } | ||
|
|
||
| public DynamicSecurityAnalysisStatus getStatus(UUID resultUuid) { | ||
| if (resultUuid == null) { |
There was a problem hiding this comment.
Maybe simplify :
return resultUuid == null ? null : dynamicSecurityAnalysisClient.getStatus(resultUuid);
basseche
reviewed
Feb 7, 2025
| return dynamicSecurityAnalysisClient.getResultsCount(); | ||
| } | ||
|
|
||
| public void assertDynamicSecurityAnalysisNotRunning(UUID resultUuid) { |
basseche
reviewed
Feb 7, 2025
| public void invalidateStatus(List<UUID> resultUuids) { | ||
|
|
||
| if (resultUuids.isEmpty()) { | ||
| return; |
There was a problem hiding this comment.
why don't you check for not empty and in this case call the rest of the code ?
Signed-off-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.