add subtype #669
Open
add subtype #669
+48
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thangqp
reviewed
Jan 31, 2025
| @@ -49,6 +49,9 @@ public class EquipmentInfos extends BasicEquipmentInfos { | |||
| @Field("equipmentType") | |||
| String type; | |||
|
|
|||
| @Field(type = FieldType.Keyword) | |||
| Set<String> equipmentSubType; | |||
There was a problem hiding this comment.
Suggested change
| Set<String> equipmentSubType; | |
| Set<String> equipmentSubTypes; |
Since it is a collection, should add 's' to the field name if the name has a same semantics
thangqp
reviewed
Jan 31, 2025
| @@ -79,6 +79,7 @@ public enum FieldSelector { | |||
| static final String EQUIPMENT_NAME = "equipmentName.fullascii"; | |||
| static final String EQUIPMENT_ID = "equipmentId.fullascii"; | |||
| static final String EQUIPMENT_TYPE = "equipmentType.keyword"; | |||
| static final String EQUIPMENT_SUB_TYPE = "equipmentSubType.keyword"; | |||
There was a problem hiding this comment.
Suggested change
| static final String EQUIPMENT_SUB_TYPE = "equipmentSubType.keyword"; | |
| static final String EQUIPMENT_SUB_TYPES = "equipmentSubTypes.keyword"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.