Skip to content

Commit

Permalink
Fix reactive threshold value when creating default parameters
Browse files Browse the repository at this point in the history
Signed-off-by: Franck LECUYER <[email protected]>
  • Loading branch information
FranckLecuyer committed Dec 17, 2024
1 parent cb03a70 commit d8429fe
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,13 @@ public VoltageInitParametersService(VoltageInitParametersRepository voltageInitP
}

public UUID createParameters(VoltageInitParametersInfos parametersInfos) {
return voltageInitParametersRepository.save(parametersInfos != null
? parametersInfos.toEntity()
: new VoltageInitParametersEntity()).getId();
if (parametersInfos != null) {
return voltageInitParametersRepository.save(parametersInfos.toEntity()).getId();
} else {
VoltageInitParametersEntity entity = new VoltageInitParametersEntity();
entity.setReactiveSlacksThreshold(DEFAULT_REACTIVE_SLACKS_THRESHOLD);
return voltageInitParametersRepository.save(entity).getId();
}
}

public Optional<UUID> duplicateParameters(UUID sourceParametersId) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.List;
import java.util.UUID;

import static org.gridsuite.voltageinit.server.service.parameters.VoltageInitParametersService.DEFAULT_REACTIVE_SLACKS_THRESHOLD;
import static org.gridsuite.voltageinit.utils.assertions.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
Expand Down Expand Up @@ -87,7 +88,7 @@ void testCreateDefault() throws Exception {
assertNull(createdParameters.getVariableTwoWindingsTransformers());
assertNull(createdParameters.getConstantQGenerators());
assertNull(createdParameters.getVoltageLimitsModification());
assertEquals(0., createdParameters.getReactiveSlacksThreshold());
assertEquals(DEFAULT_REACTIVE_SLACKS_THRESHOLD, createdParameters.getReactiveSlacksThreshold());
assertEquals(0., createdParameters.getShuntCompensatorActivationThreshold());
assertFalse(createdParameters.isUpdateBusVoltage());
}
Expand Down

0 comments on commit d8429fe

Please sign in to comment.