Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSON extraction, add extraction to Task Memory #1044

Closed
wants to merge 1 commit into from

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Aug 5, 2024

Describe your changes

Added

  • extract_json and extract_csv Activities to TaskMemoryClient.
  • extract_json_namespace and extract_csv_namespace methods to TaskMemory.

Changed

  • BREAKING: Split parameter JsonExtractionEngine.template_generator into system_template_generator and user_template_generator.
  • BREAKING: Split parameter CsvExtractionEngine.template_generator into system_template_generator and user_template_generator.
  • BREAKING: Split JsonExtractionEngine.extract into extract_text and extract_artifacts.
  • BREAKING: Split CsvExtractionEngine.extract into extract_text and extract_artifacts.
  • Parse json from LLM output before loading in JsonExtractionEngine.

Fixed

  • Missing implementations of csv_extraction_engine and json_extraction_engine in TextArtifactStorage.

Issue ticket number and link

Closes #1024


📚 Documentation preview 📚: https://griptape--1044.org.readthedocs.build//1044/

@collindutter collindutter force-pushed the feature/extraction-improvements branch from 7d48ca3 to af3d0f2 Compare August 5, 2024 17:24
@collindutter collindutter deleted the feature/extraction-improvements branch August 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV and JSON extraction engines are not implemented on TextArtifactStorage
1 participant