-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored tools to not utilize manifest.yaml #1226
Conversation
Do we have an Issue or other information on why this change is being made and what its impact is? |
@collindutter requested I remove this from the framework. |
@cjkindel We've got an internal issue for this. |
@@ -4,24 +4,11 @@ Building your own tools is easy with Griptape! | |||
|
|||
To start, create a directory for your tool inside your project. All tool directories should have the following components: | |||
|
|||
* `manifest.yml` with a YAML manifest. | |||
* `tool.py` file with a tool Python class. | |||
* `requirements.txt` file with tool Python dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@william-price01 while we're already in here, can you test if this is true? I think this is optional I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test if requirements.txt is required, if your tool must be called tool.py?
@collindutter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, both would be good to test.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Let's hold off on this one as we might actually start using it for hosted tools. |
@vasinov and I talked offline. We're going to move forward with this change. Any hosted tool manifest will be a file unique to that cloud feature, not a part of the framework. |
c6e7b1d
to
31de3ea
Compare
Describe your changes
Removed manifest.yaml requirements.
Issue ticket number and link
📚 Documentation preview 📚: https://griptape--1226.org.readthedocs.build//1226/