Catch errors from event driver publish retries #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
vachillo
changed the title
CHANGELOG.md
Outdated
| @@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - Structures not flushing events when not listening for `FinishStructureRunEvent`. | |||
| - `EventListener.event_types` and the argument to `BaseEventListenerDriver.handler` being out of sync. | |||
| - Methods `_safe_publish_event_payload` and `_safe_publish_event_payload_batch` on `BaseEventListenerDriver` not catching exceptions after failed retries. | |||
There was a problem hiding this comment.
This is unreleased, don't need to mention this fix.
collindutter
previously approved these changes
Oct 16, 2024
collindutter
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The error statement was always getting logged, regardless of success or failure
Issue ticket number and link
📚 Documentation preview 📚: https://griptape--1264.org.readthedocs.build//1264/