Add Prompt Driver extra params field #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
vachillo
reviewed
Oct 28, 2024
| @@ -128,6 +128,7 @@ def _base_params(self, prompt_stack: PromptStack) -> dict: | |||
| else {} | |||
| ), | |||
| **({"preamble": preamble} if preamble else {}), | |||
| **self.extra_params, | |||
There was a problem hiding this comment.
question for all, should extra_params be able to overwrite all other parameters?
There was a problem hiding this comment.
my suspicion is yes, but it could lead to weird behavior
There was a problem hiding this comment.
While it could allow users to shoot themselves in the foot, I don't think we should block behavior.
vachillo
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added
BasePromptDriver.extra_paramsfor passing extra parameters not explicitly declared by the Driver.Changed
HuggingFaceHubPromptDriver.params, useHuggingFaceHubPromptDriver.extra_paramsinstead.HuggingFacePipelinePromptDriver.params, useHuggingFacePipelinePromptDriver.extra_paramsinstead.Issue ticket number and link
Closes #236
Closes #293