Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drivers-prompt-openai): conditionally add modalities/reasoning_effort based on model #1668

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

vachillo
Copy link
Member

Describe your changes

Fix driver for reasoning models

openai.BadRequestError: Error code: 400 - {'error': {'message': "Unknown parameter: 'modalities'.", 'type': 'invalid_request_error', 'param':        
                             'modalities', 'code': 'unknown_parameter'}}     

Issue ticket number and link

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@collindutter collindutter changed the title Fix OpenAiChatPromptDriver for reasoning models fix(drivers-prompt-openai): conditionally add modalities/reasoning_effort based on model Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants