Refactor how configs work #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collindutter
force-pushed
the
refactor/default-configs
branch
2 times, most recently
from
e7d5fb8 to
f7ad35a
Compare
dylanholmes
previously approved these changes
May 3, 2024
collindutter
force-pushed
the
refactor/default-configs
branch
from
2ff3632 to
30bf66a
Compare
Originally they were added here to make configuring Task Memory easier. Though in reality it didn't really make it much easier and just over-complicated the Config classes. Instead, this PR makes it easier to configure Task Memory without the need of a Config class. More details on how to do this will come in #757 |
dylanholmes
previously requested changes
May 17, 2024
collindutter
force-pushed
the
refactor/default-configs
branch
2 times, most recently
from
e0e0adb to
8f14657
Compare
collindutter
force-pushed
the
refactor/default-configs
branch
from
b664e94 to
fc427c7
Compare
vachillo
previously approved these changes
May 20, 2024
vachillo
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructureConfigclasses by moving Driver config to top level.task_memoryconfig from Config classes.📚 Documentation preview 📚: https://griptape--765.org.readthedocs.build//765/