Add RedisConversationMemoryDriver
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
66
to
70
| host="127.0.0.1", | ||
| port=6379, | ||
| password='', | ||
| index='griptape_converstaion', | ||
| conversation_id = conversation_id |
There was a problem hiding this comment.
Can you please move these to env vars and update github integ tests file?
pyproject.toml
Outdated
| @@ -93,6 +94,7 @@ drivers-web-scraper-markdownify = ["playwright", "beautifulsoup4", "markdownify" | |||
| drivers-event-listener-amazon-sqs = ["boto3"] | |||
| drivers-event-listener-amazon-iot = ["boto3"] | |||
|
|
|||
|
|
|||
poetry.lock
Outdated
There was a problem hiding this comment.
This seems like an overly-changed lock file for just adding an extra. Can you try regenerating using the one from dev?
There was a problem hiding this comment.
copied from dev and ran poetry lock --no-update
collindutter
approved these changes
May 16, 2024
hkhajgiwale
pushed a commit
to hkhajgiwale/griptape
that referenced
this pull request
May 25, 2024
Co-authored-by: torabshaikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #710
closes #389
📚 Documentation preview 📚: https://griptape--787.org.readthedocs.build//787/