RavenDB-22986 - improve the performance of getting the free pages count

grisha-kotler · Oct 10, 2024 · 35351ea · 35351ea
1 parent e66049b
commit 35351ea
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 0 deletions.
diff --git a/src/Voron/Impl/FreeSpace/FreeSpaceHandling.cs b/src/Voron/Impl/FreeSpace/FreeSpaceHandling.cs
@@ -349,6 +349,31 @@ public List<long> AllPages(LowLevelTransaction tx)
             }
         }
 
+        public int GetFreePagesCount(LowLevelTransaction tx)
+        {
+            var freeSpaceTree = GetFreeSpaceTree(tx);
+            if (freeSpaceTree.NumberOfEntries == 0)
+                return 0;
+
+            using (var it = freeSpaceTree.Iterate())
+            {
+                if (it.Seek(0) == false)
+                    return 0;
+
+                var count = 0;
+
+                do
+                {
+                    var stream = it.CreateReaderForCurrent();
+                    var current = new StreamBitArray(stream);
+                    count += current.GetNumberOfSetBits();
+
+                } while (it.MoveNext());
+
+                return count;
+            }
+        }
+
         public void FreePage(LowLevelTransaction tx, long pageNumber)
         {
             if (_guard.IsProcessingFixedSizeTree)

diff --git a/src/Voron/Impl/FreeSpace/IFreeSpaceHandling.cs b/src/Voron/Impl/FreeSpace/IFreeSpaceHandling.cs
@@ -6,6 +6,7 @@ public interface IFreeSpaceHandling
     {
         long? TryAllocateFromFreeSpace(LowLevelTransaction tx, int num);
         List<long> AllPages(LowLevelTransaction tx);
+        int GetFreePagesCount(LowLevelTransaction txLowLevelTransaction);
         void FreePage(LowLevelTransaction tx, long pageNumber);
         long GetFreePagesOverhead(LowLevelTransaction tx);
         IEnumerable<long> GetFreePagesOverheadPages(LowLevelTransaction tx);

diff --git a/src/Voron/Impl/FreeSpace/NoFreeSpaceHandling.cs b/src/Voron/Impl/FreeSpace/NoFreeSpaceHandling.cs
@@ -14,6 +14,11 @@ public List<long> AllPages(LowLevelTransaction tx)
             return new List<long>();
         }
 
+        public int GetFreePagesCount(LowLevelTransaction txLowLevelTransaction)
+        {
+            return 0;
+        }
+
         public void FreePage(LowLevelTransaction tx, long pageNumber)
         {
 

diff --git a/src/Voron/Impl/FreeSpace/StreamBitArray.cs b/src/Voron/Impl/FreeSpace/StreamBitArray.cs
@@ -35,6 +35,7 @@
 using System;
 using System.Diagnostics;
 using System.IO;
+using System.Numerics;
 using Sparrow.Server;
 
 namespace Voron.Impl.FreeSpace
@@ -110,6 +111,18 @@ public bool Get(int index)
             return (_inner[index >> 5] & (1 << (index & 31))) != 0;
         }
 
+        public int GetNumberOfSetBits()
+        {
+            var count = 0;
+
+            for (int i = 0; i < _inner.Length; i++)
+            {
+                count += BitOperations.PopCount((uint)_inner[i]);
+            }
+
+            return count;
+        }
+
         public void Set(int index, bool value)
         {
             if (value)