-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Makefile #99
base: public
Are you sure you want to change the base?
Fix Makefile #99
Conversation
This PR fixes #96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile.in mustn't be part of repository. (Means you should drop that change from the commit, and leave only the proper one, i.e. in Makefile.am)
That's not dogma. There are several approaches to Autotools with version control systems. See comparisons: |
I've seen many repositories include |
If they are all wrong, why should be you? https://en.wikipedia.org/wiki/Cargo_cult_programming And to my point: VCS and release tarball are different in this case. when you build your release with |
The idea is that you clone the repo, run |
I have updates my comment above. For your convenience repeating here the additional part: And to my point: VCS and release tarball are different in this case. when you build your release with To @mymedia2: See above as well. Feel free to ask additional questions if you have something to be cleared. |
@andy-shev but your link says nothing about version control systems. Why do not you admit a workflow with generated files in Git? It is discussed in Automake docs. |
It's suboptimal to have generated files under VCS. User will regenerate them anyway (you never know what the actual version of autotools on the user's side). I see only disadvantages of this. And on top of that the standard de facto is to produce releases. If you do tags in VCS it's user's responsibility to generate necessary files on their side. |
Makefile templates are missing
video/VideoPacketSender
andvideo/VideoFEC
includes