update pyodide sandbox version #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest grist-core, which has significant improvements to the pyodide sandbox packaging.
alexmojaki
approved these changes
Aug 3, 2023
|
@alexmojaki do you happen to know if there's an easy way to pick up the standard-library-as-pyc variant? Would it be worth it? Pyodide is currently used like this: https://github.com/gristlabs/grist-core/blob/d12d971162c451dd6fb0b42878f2aec50a351e8f/sandbox/pyodide/pipe.js#L4 |
|
Try |
Would this introduce a new dependency on the network being available, or is that dependency already there in pyodide? |
|
I think it would. Does grist-electron work offline? |
|
Yes, grist-electron works offline, and that is a useful property in a desktop app. So I'll skip the standard-library-pyc part for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest grist-core, which has significant improvements to the pyodide sandbox packaging. The main advantages are less delay before a document becomes editable, and less delay at the start of imports.