copy grol's workflow #16
Conversation
| tags: | ||
| # so a vX.Y.Z-test1 doesn't trigger build | ||
| - 'v[0-9]+.[0-9]+.[0-9]+' | ||
| - 'v[0-9]+.[0-9]+.[0-9]+-pre*' |
There was a problem hiding this comment.
| - 'v[0-9]+.[0-9]+.[0-9]+-pre*' | |
| - 'v[0-9]+.[0-9]+.[0-9]+-pre.*' |
Otherwise you accept only pr, pre and variation of preeeeee
There was a problem hiding this comment.
thank I fixed that bug in fortio/workflows but when I copied pre workflow files from multicurl I forgot about, nice catch
| push: | ||
| tags: | ||
| # so a vX.Y.Z-test1 doesn't trigger build | ||
| - 'v[0-9]+.[0-9]+.[0-9]+' |
There was a problem hiding this comment.
I would have expected to see a $
| - 'v[0-9]+.[0-9]+.[0-9]+' | |
| - 'v[0-9]+.[0-9]+.[0-9]+$' |
Because otherwise the second regexp is useless, but also it lets me think this regexp is catching the -test tags you talk about
There was a problem hiding this comment.
I thought it's a full match but given pre1,2 etc did build, probably not
There was a problem hiding this comment.
it's weird and I'll admit, don't have time to figure out but... it works grol-io/grol#51
| go-version: '1.22' | ||
| check-latest: true |
There was a problem hiding this comment.
I think providing the second implies the first one is useless
There was a problem hiding this comment.
no it stays on 1.22 (1.21 before) even when 1.23 ships
No description provided.